Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in planning_reserves #135

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

DesmondZhong
Copy link
Contributor

There is a small typo in the file, which is fixed by this commit.

@mfripp mfripp changed the base branch from master to next_release October 27, 2022 22:08
@mfripp
Copy link
Member

mfripp commented Oct 27, 2022

I would call the later commit more of a change in behavior than a fix for errors. As far as I can tell, incremental and total capacity for storage gens were both being written to storage_builds.csv, but this is a request to split the output into storage_builds.csv and storage_capacity.csv to reduce confusion. I'm merging it on that basis, but expect to turn around and immediately combine this with some changes to gen_cap.csv, so there will be a gen_cap.csv and gen_additions.csv, and both of these will have columns for generator power capacity and energy capacity (the latter only applies to storage).

@mfripp mfripp merged commit f8bfae0 into switch-model:next_release Oct 27, 2022
staadecker pushed a commit that referenced this pull request Jan 28, 2023
fix typo in planning_reserves and split storage_builds.csv into storage_builds.csv and storage_capacity.csv
staadecker pushed a commit that referenced this pull request Jan 28, 2023
fix typo in planning_reserves and split storage_builds.csv into storage_builds.csv and storage_capacity.csv
staadecker pushed a commit that referenced this pull request Jan 29, 2023
fix typo in planning_reserves and split storage_builds.csv into storage_builds.csv and storage_capacity.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants